-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3.0 - Yarn language v3 features #75
Open
dogboydog
wants to merge
31
commits into
v3_beta
Choose a base branch
from
development-v3
base: v3_beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le. fix comment references to unity
…during typewriter effect
…ewBase an interface
…ated markup palette sample
…generic AddCommandHandler
…t into development-v3 # Conflicts: # addons/YarnSpinner-Godot/Runtime/DialogueRunner.cs
…not determine type of expression' compilation errors
…alNovel sample , also demonstrates non-static YarnCommand
…dd ordinal example
dogboydog
changed the title
v0.3.0 - Yarn language 3 features
v0.3.0 - Yarn language v3 features
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcoming testing of this updated version of the plugin.
Release https://github.com/YarnSpinnerTool/YarnSpinner-Godot/releases/tag/v0.3.0-beta
⚠ Although no destructive bugs have been discovered in this beta, I highly recommend backing up / committing to version control any existing projects before testing this upgrade.
Let me know any feedback here or in the discord.
Changes
<<detour>>
and<<once>>
.[YarnCommand
] and[YarnFunction]
have been updated to generate a class calledYarnSpinnerGodot.Generated.ActionRegistration
. This class will register all of your commands and functions without relying on reflection, which was the cause of some performance hiccups when starting a scene with a DialogueRunner in v0.2.* of the pluginDialogueViewBase
interface is deprecated in favor ofAsyncDialogueViewBased
. Updated example views are provided.snake_case
version of methods onAsyncDialogueViewBase
can be added directly inYarnProject.dialogueViews
without requiring GDScriptViewAdapter. Supported methods:
on_dialogue_start_async() -> void
,on_dialogue_complete_async() -> void
,run_line_async(line: Dictionary) -> void
,run_options_async(options: Array, on_option_selected: Callable) -> void
. You can still useawait
statements in your GDScript view methods.AddCommandHandlerCallable
onDialogueRunner
has been re-tested to ensure that commands can still be registered from GDScript. Also, the GDScriptIntegration sample has been updated with these changes.TextLineProvider
instances, either via script or in the inspector.👩🚒 Getting Help
There are several places you can go to get help with Yarn Spinner.
Join the Yarn Spinner Discord (
#godot
channel).To report a bug, file an issue on GitHub.
If you would like to support the development of this plugin, other open source contributions, and video games by the maintainer,
consider donating at ko-fi.com/decrepitgames.